PowerlineApp / powerline-rn

GNU Affero General Public License v3.0
0 stars 6 forks source link

Release A - Critical Bug - Hide Share Button on Private Group Items #240

Closed jterps08 closed 6 years ago

jterps08 commented 6 years ago

Share button should only appear on Item Detail Screen for items in public groups (e.g. town/state/country). If this is not easily possible with current JSON response, then only show if user is author of the post for release A and assign backend work to Igor as needed.

image

piubellofelipe commented 6 years ago

is verifying if "group_type_label" is "local", "state" or "country" enough for displaying the share button, or there are more types of group? the current JSON type I receive is:

group:
{ type: 'group',
avatar_file_path: 'https://powerline-dev.imgix.net/avatars/src/59bbd398e3f7e948409717.png?ixlib=php-1.1.0',
banner: null,
group_type_label: 'local',
user_role: 'member',
id: 422,
official_name: 'Elizabeth' },
jterps08 commented 6 years ago

@piubellofelipe yes. if its local state or country, it's enough.

piubellofelipe commented 6 years ago

via Hubstaff User: Felipe Piubello

Project: Powerline React Native - https://app.hubstaff.com/projects/264175 Date Range: 10/31/17 - 10/31/17 Work session total: 0:13:15

Grand total: 0:13:15