search

Pr0Ger / PyAPNs2

Python library for interacting with the Apple Push Notification service (APNs) via HTTP/2 protocol
MIT License
349 stars 179 forks source link

add proxy support to connection #46

Closed jsmolina closed 6 years ago

jsmolina commented 7 years ago

Sometimes your host needs to jump a host to reach internet.

This change adds support for proxy in libary in the simplest way as HTTP20Connection already supports the proxy param.

jsmolina commented 6 years ago

@Pr0Ger ?

Pr0Ger commented 6 years ago

Yea, sorry it took so long to review this PR. I think it's better to pass these params directly to Credentials.create_connection method instead of saving them inside Credentials constructor (same way how force_proto param is handled).

jsmolina commented 6 years ago

agree with you, changed so @Pr0Ger

Pr0Ger commented 6 years ago

@jsmolina thx for contribution