Practically / PsalmPluginYii2

Psalm plugin for a better typed yii2 application
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Create BaseYii stub #6

Closed WinterSilence closed 2 years ago

WinterSilence commented 3 years ago

@AdeAttwood I take that code from package https://github.com/proget-hq/phpstan-yii2

AdeAttwood commented 3 years ago

This code is good as is, just needs some tests. @WinterSilence would you like me to finish this PR off and push the changes to WinterSilence/PsalmPluginYii2

WinterSilence commented 3 years ago

@AdeAttwood

would you like me to finish this PR off and push the changes to WinterSilence/PsalmPluginYii2

don't understand you

WinterSilence commented 3 years ago

@AdeAttwood don't know how test stubs, but if is work fine in phpstan plugin it's must work fine in psalm plugin too

AdeAttwood commented 3 years ago

but if is work fine in phpstan plugin it's must work fine in psalm plugin too

Unfortunately to often this is not the case. I will get some test done and get this merged in the next couple of days.

WinterSilence commented 3 years ago

@AdeAttwood merged with stub generated by psalm --generate-stubs

AdeAttwood commented 2 years ago

@WinterSilence thanks for this, sorry for the delay it has been put in with #9 with the tests. If you want to see how the tests are done for the stubs, then you can see them here