PradyumnaKrishna / enigma-protocol

An end to end encrypted messenger using Flask, SocketIO, and Vue.js
https://protocol.onpy.in
MIT License
19 stars 34 forks source link

feat: add codeql workflow #62

Closed harmeetsingh11 closed 10 months ago

harmeetsingh11 commented 10 months ago

Related Issue

Closes #58

Files added

Checklist

Please review this PR. Thanks

PradyumnaKrishna commented 10 months ago

We only need javascript codeql and please add it to https://github.com/PradyumnaKrishna/enigma-protocol/blob/main/.github/workflows/client_build.yml.

harmeetsingh11 commented 10 months ago

I think multiple workflows in single file is not supported. It would be better to have single workflow per yaml file. I have removed python and go languages from the workflow.

github-advanced-security[bot] commented 10 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

PradyumnaKrishna commented 10 months ago

I think multiple workflows in single file is not supported. It would be better to have single workflow per yaml file. I have removed python and go languages from the workflow.

Okay, This looks good to me. Before merging I have a minor request please remove all the comments in the configuration and the cron trigger.