search

Praful932 / Kitabe

Book Recommendation System built for Book Lovers📖. Simply Rate ⭐ some books and get immediate recommendations🤩
https://kitabe.up.railway.app/
MIT License
165 stars 152 forks source link

Improve UI for book list under different genre #90

Closed anjali494 closed 3 years ago

anjali494 commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] The Book Title for some books overflows the text box which makes the page look messy and confusing. Also, when you hover over the picture, it slightly enlarges which makes it look like a clickable element.

Describe the solution you'd like A clear and concise description of what you want to happen. The white background should be resized to fit the content in it. Also, change the css of the buttons to make the page more user-friendly by changing layout or adding features like hover.

Are you willing to contribute to this issue? [Yes/No] I am a participant of GSSOC'21 and would love to work on this issue

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. we can make the lists under genre similar to list under the explore page.

Additional context Add any other context or screenshots about the feature request here.

like the buttons here hide some of the text.

image

Whereas, the explore page has this layout.

image

maneprajakta commented 3 years ago

@anjali494 Please follow the issue template while creating an issue. I have edited the issue description update accordingly. Check this #58 what we aspect in an issue template. If you update we will assign this to you.

Praful932 commented 3 years ago

@anjali494 If you could attach a SS what is happening & what you expect, that would make the issue clearer

anjali494 commented 3 years ago

@maneprajakta @Praful932 i edited the issue to make it more precise. Please check it out.

maneprajakta commented 3 years ago

@anjali494 what I could get is that you want to change the design of the genre book card to what is it on explore page. Or anything else?

anjali494 commented 3 years ago

@maneprajakta yes, it would solve the above mentioned issue.

maneprajakta commented 3 years ago

@anjali494 We don't want the card design to be changed for the genre page. If you could suggest other alternatives like one could be fixing the no of lines to be displayed for book name.

Tarun-Kamboj commented 3 years ago

Yes @maneprajakta, we should limit the text displayed on both genre and explore pages so that it don't exceed to the point where it starts looking bad. And regarding the enlargement of the image on hover, we can open the details box when user clicks the image as it is a common practice to click on the image to know more about it. @Praful932 I'd like to give this a go.

Tarun-Kamboj commented 3 years ago

@Praful932, @maneprajakta Can you assign this issue to me? I'm a GSSOC21 participant too.

anjali494 commented 3 years ago

@maneprajakta we can add a feature that if the name of the book exceeds a number of characters, we can use ...

maneprajakta commented 3 years ago

@anjali494 got for it then. Also, read our Starter Guide it will help you in starting up with the project.

maneprajakta commented 3 years ago

@Tarun-Kamboj thanks for showing interest. Readout guidelines that we follow Starter Guide You can check out other issues meanwhile.

maneprajakta commented 3 years ago

@anjali494 draft a PR for changes done till now.

maneprajakta commented 3 years ago

148 will solve this