Closed jasonrclark closed 10 years ago
Thanks for these changes, they look good - the usage of instance_eval
there impressed me :)
Good catches both, I think we're set here. instance_eval
FTW! :smirk:
Hi Jason,
the slide
and initialize
method were getting a bit long for my taste :) So with the first I extracted the two parts of the method to helper methods. With the second I extracted the loading of named slides and the associated "switch" - let me know what you think, I feel unsure about the name publish_slide_classes
for instance :)
Thanks! Tobi
That all looks reasonable to me. I agree that publish_slide_classes
isn't ideal, but I don't have a better option so I'm good to roll with it.
You feel like this is ready for a merge? I've got a smattering of other stuff I've tweaked while working on my presentation that I'll PR in smaller chunks once this is landed.
Sure, just wanted to get your feedback on my changes first :-)
Should have made that clearer, you could have hit the merge button =)
Addresses #6, just for fun.
Now you can define things right in
config.rb
like this:You can also use the dsl in
slides/*.rb
files, although you'll have to give them a name to reference them later viaslides
in config, like so:Zing! :rocket: