search

PragTob / wingtips

A nice little presentation written in shoes
MIT License
12 stars 1 forks source link

Add hook for when a slide is hiding #13

Closed jasonrclark closed 10 years ago

jasonrclark commented 10 years ago

Found for my fancier slides I needed to do some cleanup (stop animations, etc.) This hook was the clearest way I could see to plumb that through.

PragTob commented 10 years ago

This seems good, although a slot level clear should do all that. I mean stop animations etc. - if you could share an example we could try to fix it over at shoes if clear doesn't have the desired effect there. :)

Writing apps is still the best thing to find bugs!

jasonrclark commented 10 years ago

So double-checked this, and we are doing a clear to remove the slide's slot which would contain the animation, so this is probably worth an upstream Shoes issue. Will log it.

jasonrclark commented 10 years ago

https://github.com/shoes/shoes4/issues/935