Closed PragTob closed 10 years ago
That all looks good to me. Only minor quibble is SlideDSL
looks a little clunky as a name to me... would just DSL
or Dsl
be acceptable since they're within the Wingtips
module?
As far as config still doing the instance_eval
, I think that actually will end up being a feature, since it makes it so we can expose configuration methods just by putting them on the Wingtips::Configuration
class without making them accessible to all the slides. Super cool!
Ran like a charm for me locally too. Nice work! :rocket:
Good point about it being name spaced under Wingtips
! =) Will change that and merge after another test run.
@jasonrclark review me maybe? Will probably merge tomorrow-ish, though, as I might need it for my talk :)