search

PragatiVerma18 / Snippet-Share

This is a snippet sharing app that can be used to share snippets of code and more.
https://snip-share.herokuapp.com/
46 stars 35 forks source link

DEBUG is set to True for Production server #39

Closed debdutgoswami closed 3 years ago

debdutgoswami commented 3 years ago

Describe the bug

Django apps should not be deployed with DEBUG=True and SECRET_KEY should be taken from an enviornment variable.

To Reproduce Steps to reproduce the behavior: Any error on the production server will trigger this. For instance reproducing issue #38 will trigger the same.

Expected behavior Even if something breaks in prodcution (which is very common for side projects), you would idealy want to show a custom page or something, even configuring nginx will give you a default page for the same.

Screenshots Refer to issue #38

Desktop (please complete the following information):

Smartphone (please complete the following information):

PragatiVerma18 commented 3 years ago

@debdutgoswami would you like to send in a PR for this issue?

debdutgoswami commented 3 years ago

Sure. I'll drop a PR