search

PragmaticFlow / Serilog.Sinks.SpectreConsole

Apache License 2.0
32 stars 7 forks source link

Updated Spectre.Console to 0.40 #5

Closed olegtarasov closed 2 years ago

SuperJMN commented 3 years ago

Why isn't this merged already? :)

AntyaDev commented 3 years ago

@SuperJMN We tried version 0.39 and noticed that it produced some errors. I didn't have a chance to check 0.40 version.

@olegtarasov Have you tried to test that it works?

olegtarasov commented 3 years ago

@AntyaDev I've just tested 0.42 and it works in my case, but so did 0.39.

AntyaDev commented 3 years ago

Hi @olegtarasov Can you please add some integration tests? (especially that tests progress bar)

olegtarasov commented 3 years ago

@AntyaDev Sorry, but I'm afraid I won't be able to carve out the time for integration tests :( I use this library in my pet project with me as the only developer and user, and I really don't mind occasional glitches with console output (not that I've experienced any). I know this is not an ideal approach for an open source contribution, but unfortunately I have to choose between writing tests and moving forward a project that is important to me.