search

Pragmatismo / Pigrow

Raspberry Pi Grow Box Control Software
GNU General Public License v3.0
146 stars 22 forks source link

Added support for al linux usernames #4

Closed niko9797 closed 6 years ago

niko9797 commented 6 years ago

Hi, nice to see how far has gone pigrow! keep up the nice job. I like this program, i will install it as soon as i got and if you want i am willing to help you in my free time. I created a fork where i changed all the directions of files with pi as user to the user that executes the program (to use it in distros like ubuntu mate or arch where u can select your username, and also because avoid using default usernames is a basic linux security guideline). Also in install.py i added some lines to create automatically on setup the dirloc file with system username.

As i saw you are now working in the remote control program, In future merges im thinking to help with portability for different raspberry OS. try to improve the functions and add new ones to the core program thru console and work on readmes and documentation to make more people interested in the program (to help with coding and to use it) but if you have some kind of roadmap or to do list could work in that line.

Appart from that i would like to suggest to take out the remote program from the principal repository to another one called pigrow-controller or something to sepparate clearly both programs as are independant.

Greetings, niko

Pragmatismo commented 6 years ago

oh that's really cool, i've been meaning to do that for ages thanks - i'll check it all over and pull it in asap. I've also been meaning to put the remote gui in it's own repo, just get so caught up doing other bits and pieces... I've got to work tomorrow but would be great to chat soon, i'll look over that and message you weds hopefully. thanks again, calvin. 

  From: niko9797 <notifications@github.com>

To: Pragmatismo/Pigrow Pigrow@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Sent: Monday, March 5, 2018 8:03 PM Subject: [Pragmatismo/Pigrow] Added support for al linux usernames (#4)

Hi, nice to see how far has gone pigrow! keep up the nice job. I like this program, i will install it as soon as i got and if you want i am willing to help you in my free time. I created a fork where i changed all the directions of files with pi as user to the user that executes the program (to use it in distros like ubuntu mate or arch where u can select your username, and also because avoid using default usernames is a basic linux security guideline). Also in install.py i added some lines to create automatically on setup the dirloc file with system username.As i saw you are now working in the remote control program, In future merges im thinking to help with portability for different raspberry OS. try to improve the functions and add new ones to the core program thru console and work on readmes and documentation to make more people interested in the program (to help with coding and to use it) but if you have some kind of roadmap or to do list could work in that line.Appart from that i would like to suggest to take out the remote program from the principal repository to another one called pigrow-controller or something to sepparate clearly both programs as are independant.Greetings, niko You can view, comment on, or merge this pull request online at:   https://github.com/Pragmatismo/Pigrow/pull/4 Commit Summary

File Changes

Patch Links:

Pragmatismo commented 6 years ago

thanks niko, great work!

niko9797 commented 6 years ago

Thanks! also more new incoming. yesterday I tried to re structure the program specially the main install and setup scripts, I think is needed for easier future implementations and functions integration you can take a look at: https://github.com/niko9797/Pigrow/tree/dev Would be cool if we can chat or whatever and discuss about this changes and the future development, if u want you can mail me at niko9797@gmail.com greetings, Niko

Pragmatismo commented 6 years ago

just looking at your work in progress interface, that's really cool looks great. 

  From: niko9797 <notifications@github.com>

To: Pragmatismo/Pigrow Pigrow@noreply.github.com Cc: Pragmatismo calvineurof@yahoo.com; State change state_change@noreply.github.com Sent: Wednesday, March 7, 2018 11:57 AM Subject: Re: [Pragmatismo/Pigrow] Added support for al linux usernames (#4)

Thanks! also more new incoming. yesterday I tried to re structure the program specially the main install and setup scripts, I think is needed for easier future implementations and functions integration you can take a look at: https://github.com/niko9797/Pigrow/tree/dev Would be cool if we can chat or whatever and discuss about this changes and the future development, if u want you can mail me at niko9797@gmail.com greetings, Niko— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.