Does not work in IE 11 - Githubissues

Pragmatists / microfrontends

105 stars 40 forks source link

Does not work in IE 11 #2

Open bollerdominik opened 4 years ago

bollerdominik commented 4 years ago

Trying to run this PoC in IE 11 I get

angular-app' died in status LOADING_SOURCE_CODE: "does not export an unmount function or array of functions"

Kindly asking for help on how to get it running on IE

joeldenning commented 4 years ago

The same error doesn't happen in other browsers? The error you're seeing is usually not browser-specific.

bollerdominik commented 4 years ago

Works fine in all other Browsers I have tested it. Just IE is throwing the error shown above

joeldenning commented 4 years ago

I just tested it out locally and confirmed it doesn't work. It seems related to Angular 5's bundle not creating the window.angularApp global variable correctly. I don't have the desire to debug this since this repo is not up-to-date on many things (Angular 5 instead of Angular 8) and not following all the best practices of single-spa (no SystemJS, UI in the root app when that's not encouraged, etc).

Check out the recommended setup by the single-spa core team.

Here are some other examples