PrairieLearn / PrairieLearn

Online problem-driven learning system
http://prairielearn.readthedocs.io/
Other
364 stars 329 forks source link

Enhancement: show pl-manual-grading-only-element to graders on all submissions in the Manual Grading interface #8452

Closed firasm closed 1 year ago

firasm commented 1 year ago

pl-manual-grading-only-element is a super useful element (documented here) that was designed to work well with recent Manual Grading features.

However, it currently doesn't show up in auto-graded questions, even when you're looking at the submission from within the Manual Grading interface (and even when "gradingMethod": "Manual" in info.json and when "manualPoints":1 in the infoAssessment.json file). .

Screenshot 2023-09-06 at 3 51 02 PM

Here is the relevant bit that I think should be viewable on any question (if <pl-manual-grading-only> is specific in question.html) when looking at it from the Manual Grading interface.

<pl-manual-grading-only>
    This is a test
<markdown>
# Grader notes

This is a really tough question ... more students than we expect get this wrong!
</markdown>
<pl-manual-grading-only>
nwalters512 commented 1 year ago

@firasm as far as I can tell, this is user error. If the HTML snippet you sent above is exactly what you have in your question, it's malformed: you need to close <pl-manual-grading-only> with </pl-manual-grading-only>, but you have two opening tags. I tested this with properly-structured HTML and it works as intended. Let me know if that's the case for you too.

firasm commented 1 year ago

HA! it was indeed user-error, but not the one you found (that was a copy/paste issue in GitHub).

I had a copy of the question in a different folder and wasn't updating the question I thought it was.

Indeed this works as expected...thank you and sorry! 🙏🏽