search

PrairieLearn / PrairieTest-feedback

Public repo to house PrairieTest bug reports, feature requests, and more
0 stars 0 forks source link

Nomalize UID capitalization #13

Open SethPoulsen opened 2 years ago

SethPoulsen commented 2 years ago

When adding an Illinois student to a class by email, if a letter in the email address is capitalized, it fails to link to their account.

It would be nice if it could figure this out and add them.

trombonekenny commented 2 years ago

Definitely seeing a lot of a Netid@illinois.edu entries on PT. I'm not sure how we fix that? Change the input form to normalize to lowercase when adding?

SethPoulsen commented 2 years ago

Could be a solution. I would first want to check with how capitalization is treated in official email protocol specs, just to make sure we don't make any choices contradictory to that.

SethPoulsen commented 2 years ago

If emails are always treated as case-insensitive in general, then that should be fine, right?

mwest1066 commented 2 years ago

These aren't technically emails, they are eduPersonPrincipalName SAML attributes: https://www.educause.edu/fidm/attributes

SethPoulsen commented 2 years ago

Good to know, but I don't see anything there about whether or not they can be case sensitive.

mwest1066 commented 2 years ago

https://wiki.refeds.org/display/STAN/eduPerson+2020-01#eduPerson202001-eduPersonPrincipalName

Looks like eduPersonPrincipalName is defined to have EQUALITY caseIgnoreMatch so we should indeed be doing a case-insensitive match on the UID.

Also see https://shibboleth.atlassian.net/browse/SSPCPP-721 for some mess around this.

SethPoulsen commented 2 years ago

Wow, that really is a mess.