search

PrajjwalDatir / Kaoi

Easy to Deploy, Fork, and Edit WhatsApp Botto. Not Maintained Anymore. Feel Free To Use As Per The License.
GNU Affero General Public License v3.0
145 stars 173 forks source link

Update EventHandler.ts #225

Closed Raj6544 closed 2 years ago

Raj6544 commented 2 years ago

A little bit change

PrajjwalDatir commented 2 years ago

I believe that saying the person has left the chat is better. we will miss you is dependent on situation.

What do you think? @Raj6544

Raj6544 commented 2 years ago

Ok then just Bye message ... It will be right?? @PrajjwalDatir

PrajjwalDatir commented 2 years ago

Why are you trying to change the original? @Raj6544

Raj6544 commented 2 years ago

Ummm, if anyone left the gc then user already can see user lefting chat. That's why I was trying to replace by 'Bye'. It can be annoying for if anyone left chat that already can see but again if it repeating 'user left chat' then it could be annoying in my views.

Or it can be - "user left the chat. Bye 👋" @PrajjwalDatir

PrajjwalDatir commented 2 years ago

if anyone left the gc then user already can see user lefting chat

  • we see the number as leaving ( unless we've saved the number )
  • Sometimes Bot might respond late, so we might not get the 'bye' message as soon as user has left.
  • I'm ok with the user left the chat. Bye 👋 part. But I think that's an unnecessary change.

Closing PR.