search

Prajwal0225 / My-Favorite-SuperHero

🦸‍♂️ My Fav Superhero: Discover superhero images in a click! Search your heroes or get random image.
https://my-favorite-super-hero-one.vercel.app/index.html
MIT License
24 stars 84 forks source link

Invalid Search Improvement #264

Closed Tanya347 closed 1 year ago

Tanya347 commented 1 year ago

On searching something invalid, we can still see the download button. I think it would be more comprehensive to not let the user search the wrong thing in the first place i.e. when they click on the search button there should be a small popup to alert the user that it is invalid, and clear the search input. Please let me work on this issue

image

github-actions[bot] commented 1 year ago

👋 @Tanya347 Thank you for raising an issue. We will investigate the matter and get back to you as soon as possible 🚀. Please make sure you have given us as much context as possible. Additionally, consider giving our repository a star. ⭐ It will motivate us to do more!

Prajwal0225 commented 1 year ago

You can start working on this issue.

Tanya347 commented 1 year ago

Since someone already added this feature before I could I'm just going to fix this : image

and make this area more readable: image