search

Prakash2403 / ultron

Personal Assistant
MIT License
14 stars 5 forks source link

Google search #19

Closed neelanshsahai closed 7 years ago

neelanshsahai commented 7 years ago

@Prakash2403 @Monal5031 @aashutoshrathi any suggestions for the pre_execute and the post_execute methods

aashutoshrathi commented 7 years ago

Can't we use https://pypi.python.org/pypi/search-google/1.0.3 or https://pypi.python.org/pypi/google instead

neelanshsahai commented 7 years ago

@aashutoshrathi OK I ll check it.... I think we can use the webbrowser module for #11 or can we use this search-google there as well ?

Monal5031 commented 7 years ago

self.search_query = '' seems like redundant 😕

Monal5031 commented 7 years ago

Also @neelanshsahai sir , in pre_execute you can print a statement ('enter your query') so that user can directly use the feature but just giving its query. But then in execute you will have to do (search_query='`some_default_query') in case of empty input.