search

Pralish / instructify

0 stars 0 forks source link

feat: adding blog-features to the roadmaps #16

Closed Riteshchaudhary710 closed 1 year ago

Riteshchaudhary710 commented 1 year ago

Closes #14 Basic UI design This PR adds only basic UI design for the roadmap blog.

Note: UI design should be categorized as basic, intermediate, and advanced so we can know on which level our UI design is right now.

Pralish commented 1 year ago

@Riteshchaudhary710 , Is this PR ready? I don't see the view being used.

Please update this file instead of creating new one.

https://github.com/Pralish/instructify/blob/e39ccd5f1cc05649e3164f99a50b5e90961b8d3e/app/views/roadmaps/show.html.haml

Pralish commented 1 year ago

@Riteshchaudhary710 , What's the ETA on this task?

Riteshchaudhary710 commented 1 year ago

@Pralish , I think this week. Also on which basis do we fetch related posts?

Pralish commented 1 year ago

@Riteshchaudhary710 , Just show first 5 for now. We will refactor later when we add categorization, and much later based on recommandation system.

Riteshchaudhary710 commented 1 year ago

@Pralish, what about the blog image I did not see any attribute related to it.

Pralish commented 1 year ago

@Riteshchaudhary710 , I haven't setup active storage yet. Please setup active storage and add fields as needed

Pralish commented 1 year ago

@Riteshchaudhary710

Issues on smaller screens:

Screenshot 2023-09-02 at 10 42 16 PM Screenshot 2023-09-02 at 10 42 39 PM
Pralish commented 1 year ago

@Riteshchaudhary710 ,

https://github.com/Pralish/instructify/pull/16/commits/3beafa4b3e90741cdcfac2925416332668005580

Pralish commented 1 year ago

https://github.com/Pralish/instructify/assets/50227291/d027ad45-0a3f-47a1-b6ae-022d4efe4dfd

@Riteshchaudhary710 , This is not right. The background color of cards should not be pink. Please be aware of variables you are changing or any changes you are making. Always check if they are being used somewhere else. Your changes should not break existing features.

Riteshchaudhary710 commented 1 year ago

oh you already fixed here https://github.com/Pralish/instructify/commit/3beafa4b3e90741cdcfac2925416332668005580

Pralish commented 1 year ago

@Riteshchaudhary710 , I am still seeing hex on css. Can you please spend some time and look careefully and replace them with css variables.