PranabKumarSahoo / sql-dev-tools

A tool for SQL Developers, which empowering SQL developers with versatile functionalities and make their day-to-life tasks easy.
https://sql-dev-tool.web.app/
MIT License
14 stars 19 forks source link

Resolve Issue: #33 BUG-Fix: overlapping of drop constraints and count row #34

Closed kherkatary closed 10 months ago

kherkatary commented 10 months ago

Resolve issue: #33 Overlapping of differnet Sections in diffrent scaling of screens

Changes made :

BUG : - The count overlaps with the drop section

issue_2

Resolved BUG : -

issue_fix

PranabKumarSahoo commented 10 months ago

Hello @kherkatary,

Thank you for your contribution and the changes you made to address the issue #33 regarding the overlapping of sections on different screen scalings. I appreciate your efforts in improving the codebase.

Upon reviewing the changes, I noticed that in HomePage.jsx, the IDs associated with each section were removed. While your intention to reduce code complexity is commendable, it's important to consider the functionality associated with these IDs, particularly for smooth navigation.

The previous IDs were utilized for linking purposes, enabling users to navigate directly to a specific section by clicking on the corresponding link in the navbar. With the removal of these IDs, this functionality might be affected.

I recommend considering a solution that maintains both the code simplicity and the expected functionality. So, make sure to test everything before submitting the PRs.

Please review this aspect, and if needed, we can discuss further more.

Thank you for your understanding, and I look forward to your continued contributions.


#Good Luck! ✌️

kherkatary commented 10 months ago

Okay Thank you, I will work on it

kherkatary commented 10 months ago

The navigation from the side-bar to the individual section is not working in my laptop. So it slipped through. But unlike the one deployed in the server where the navigation works fine, when i clone it, the navigation doesnt work in my laptop. Can you suggest any solution?. I cloned it again but still same issue.

PranabKumarSahoo commented 10 months ago

Hello @kherkatary,

I understand the challenge you're facing with the navigation from the side-bar not working on your laptop.

But, I've cloned the recent repository on my device, and I've created a short video demonstrating the navigation working correctly. You can view the video here:

https://github.com/PranabKumarSahoo/sql-dev-tools/assets/118038201/967f975b-e2b0-42f8-9cba-b0a0127a4760

Try to check your code again.

kherkatary commented 10 months ago

Hey @PranabKumarSahoo , can you once review with my lastet commit, i restored the original code in home.js and have made changes only in one file, Home.css, and only the heights are changes. The changes should remove the overlapping bug while keeping the navigation part untouched.

PranabKumarSahoo commented 10 months ago

Cool @kherkatary! ⭐ Good job. I'm merging the PR now.

Thanks for the contribution. Feel free to contribute more.


#Good Luck! ✌️

kherkatary commented 10 months ago

@PranabKumarSahoo Thank You :smile: