search

PranabKumarSahoo / sql-dev-tools

A tool for SQL Developers, which empowering SQL developers with versatile functionalities and make their day-to-life tasks easy.
https://sql-dev-tool.web.app/
MIT License
14 stars 19 forks source link

guide button #47

Closed ayann07 closed 9 months ago

ayann07 commented 9 months ago

Pull Request Related Issues: [List any related issues or reference them using the syntax #issue_number.]

Fixes #(issue number) Issue Number : #16 is now fixed Description: [Provide a brief description of your changes.] I have created guide button for all the sections. Checklist:

[yes] I have tested my changes. [yes] My code follows the project's coding standards. I have updated the documentation (if applicable).

Demo video:

https://github.com/PranabKumarSahoo/sql-dev-tools/assets/126085856/8fbc36b2-ec9a-4834-9ffb-2dc91d3453c5

Additional information I have worked under Social Winter Of Code 2024. Please provide any other information that you think may be relevant to the pull request.

PranabKumarSahoo commented 9 months ago

Hello @ayann07,

Firstly, I'd like to extend my apologies for the delay in reviewing your pull request. I appreciate your effort.

After going through your guide button implementation, I must say you've done a great job implementing the functionality and incorporating user-friendly features.

And I noticed in your code that you've included the guidance text directly within the function for each tool section. To enhance the code modularity, you can create a separate GuideTexts.js file in a data folder within src, to store the every section's guidance text.

For example,

folderStructure

guideTextFile

buttonFunct

This approach allows you to import the text into each tool section, & helps keep the code modular and makes it easier to update the guidance text across all sections. Right!!!

BTW, Great work so far! Looking forward to more contributions.

Good Luck!✌️

ayann07 commented 9 months ago

I have now made the necessary which were required , please check now.

PranabKumarSahoo commented 9 months ago

Cool! ⭐ Good job @ayann07, Now I'm merging the PR.

Thanks for your contribution. Feel free to contribute more.

#Good Luck! ✌️