Closed mansi1309 closed 9 months ago
Hello @mansi1309,
I appreciate your effort in contributing to our project by adding a Footer.
I noticed a couple of points in your pull request that I would like to discuss:
Links in Footer Lists: I can see from the screenshot that you're provided, some of the links you added in the footer lists (company, products, accounts, etc.) are not relevant to our SQL Dev Tools project. Please ensure that the links and content align with the purpose of our project.
Project Structure in React: As you can see this is a React project & in React, we typically handle components and styles within the src
directory, not in the public
directory. I noticed your file changes that you're adding the footer code in index.html
file, it's totally wrong in React. For the footer component and styles, we consider creating a new component file (e.g., Footer.js) within the src
directory or in pages folder within the src
directory, and a separate CSS file if needed. This will follow the standard structure of React projects.
Note: Considering these points, I recommend focusing on HTML, CSS, and JavaScript projects first to build a solid foundation before transitioning into React. React introduces additional concepts that may be overwhelming without a strong understanding of the basics.
I appreciate your effort, and I encourage you to continue learning and contributing to open source projects (I recommend you to focus on simple HTML, CSS & JS project for contribution). If you have any questions or need guidance, feel free to ask. Unfortunately, I couldn't approve this pull request in its current state due to the mentioned concerns.
Thank you for your understanding, and I look forward to seeing your future contributions!
If you have any questions or need clarification, don't hesitate to ask in the comments or on Discord [Find #sql-dev-tools channel].
#Good luck! ✌️
Pull Request Related Issues: [List any related issues or reference them using the syntax #issue_number.]
Fixes #45
Description: [I am adding a footer section in it.]
Checklist:
I have tested my changes. My code follows the project's coding standards. I have updated the documentation (if applicable). Screenshots: [If applicable, include screenshots to help reviewers understand your changes.]
Additional information
Please provide any other information that you think may be relevant to the pull request.