Closed Pranav-Patani closed 1 month ago
Issues will only be autoclosed if using one of the following keywords: close closes closed fix fixes fixed resolve resolves resolved
After solving a comment, you should also reply to the comment so that the reviewer knows which comment got solved
Please check if the target branch is correct. Do you want to merge these in file_structure branch?
Also in the diff I can see files related to sass getting deleted, but they were never added before. Why are they showing up here then?
Consider squashing commits like testing one together - https://www.git-tower.com/learn/git/faq/git-squash
Please check if the target branch is correct. Do you want to merge these in file_structure branch?
Yes, while creating the dev_tools branch, I stacked it under file_structure branch, so now it will be merged in that order.
Also in the diff I can see files related to sass getting deleted, but they were never added before. Why are they showing up here then?
![]()
These were added in its parent, file_structure branch, so when I created the child branch these changes were carried. After adding stylelint I got to know it does not allow empty files to be committed so had to delete them.
Changes in dev_tools can overwrite file_structure branch as it has both the structure and tools set up, then the sass files will be added with the next branch with basic css applied.
Please check if the target branch is correct. Do you want to merge these in file_structure branch?
Yes, while creating the dev_tools branch, I stacked it under file_structure branch, so now it will be merged in that order.
But file_structure
is already merged in main
right?
After adding stylelint I got to know it does not allow empty files to be committed
But if these changes were already part of a branch that is merged in main
then you should not need to delete them as they will not show in diff? 🤔 Like if they are already committed is stylelint still showing error in them?
@Pranav-Patani Need to change the target branch to main
This PR resolves #3 Dev tools include: