search

PranavMaganti / compose-material-dialogs

A Material Dialog Builder for Jetpack Compose
Other
604 stars 79 forks source link

Support first days of the week other than Sunday #146

Closed noe closed 2 years ago

noe commented 2 years ago

Is your feature request related to a problem? Please describe. The date picker dialog does not support having a first day of the week other than Sunday. According to Wikipedia, the week starts on Monday on most European countries, most of Asia and Oceania. Therefore, supporting only Sunday as first day of week makes it a problem for a large part of the world.

Describe the solution you'd like A new parameter in datepicker for the first day of the week, defaulting to Sunday to keep backwards compatibility.

Describe alternatives you've considered I thought of messing with DatePickerState.dayHeaders, but it won't work. This change has to be made in DatePickerImpl and the associated classes.

PranavMaganti commented 2 years ago

The first day is now set based on device locale and can be modified using a parameter as of 0.7.1