Support Compose Multiplatform

[StefanOltmann]

Thank you for making this nice components for Jetpack Compose! 👍

I would like to use the date picker on a project using JetBrains fork compose-jb.

Currently it can't be used for some reasons in "commonMain" and is filtered out. I don't understand right now how this filtering works there.

I tried to copy the classes to my project and see if it works this way. Thereby I figured out that most (nearly all) of the code compiles and seems to be compatible already. Just some Android specialities like the @StringRes annotation do not work.

I was thinking that you could strip out Android helper methods and special stuff to an additional package and have a package that's purely compose and would work for compose-jb also.

What do you think?

[PranavMaganti]

This is something which I've been looking into over the past couple of weeks and would definitely love to support. I've been a bit busy doing some other projects and adding automated tests for this library but I'll probably start working on this sometime next week. I'll probably do something similar to what you mentioned about the android specific stuff and then should just be able to put the rest of the code into common section. I was also thinking of providing desktop specific implementations for the date and time pickers as the Material spec gives a slightly extended design for them when displaying on wider screens.

[PranavMaganti]

Just a little update on this topic both for anyone interested and for myself to refer back to. I've done some work on the stuff mentioned and have currently got a working template for the module structure for the library with common, android and desktop targets for each module. I've had a look into the Dialog API for both Android and desktop versions and it looks like there are some minor differences in the parameters that they take. I think it should be possible to make an expect dialog composable in the common module and add their actual implementations for them in the android and desktop modules. As far as I could tell except for this the rest of the code can just be copied pasted into the respective common modules as it shouldn't be dependent on any platform specific composables (except for a couple of functions which have android specific stuff mentioned above).

While setting up the new project I also realised that the compose android dependency is a Jetbrains built one and not the same as the one supplied by Google. I found some discussions on the compose-desktop slack channel about unifying the dependencies but this very much seems like something which will be introduced farther down the line. Unfortunately this does mean that I'm going to have to make separate releases for the Google/Android specific build and a Jetbrains multi-platform build. I'll create a branch in the next week or so with the stuff I've done so far so that anyone who is interested can keep an eye on it.

[wakaztahir]

When is this happening , If you'd like some help , I can try to convert them for you to kotlin multiplatform and make a pull request if I succeed

[PranavMaganti]

@wakaztahir I'm extremely busy at the moment so feel free to pick this up and submit a pull request. I already got started on this in the compose-jb branch if I remember correctly but that will probably be quite outdated at this point. Good luck and let me know if you have any questions.

[wakaztahir]

Hi @vanpra , So I have made the modules but still I need to make LocalDate and LocalTime multiplatform I have tried my best to not avoid introducing any breaking changes.

https://github.com/timeline-notes/compose-material-dialogs/tree/multiplatform

Here's the list of changes on Android

• String resources aren't accepted as a parameter , straight up text : String is accepted , that's because Context was being used to get the string resources and instead of jetpack compose function stringResource() I have changed all the entries , I will slowly convert those entries to stringResource function in the demo android module
  • Instead of passing DialogProperties , you need to pass MaterialDialogProperties which contains the same properties and has a nice constructor , since DialogProperties isn't available on Desktop Jetpack Compose and desktop uses DialogState so I used both of their parameters to create a new class

That's all the changes in the api

Bugs :

• The Desktop Horizontal Pager doesn't work
• I still need to convert LocalDate and LocalTime to multiplatform , they aren't supported and that's why iibraries can't be published as multiplatform
• Time picker is not allowing clickable selection of 1 - 9 Hour Time , I don't know if I introduced this bug but I kept the code same and shifted most of what worked on android to android , but you need to see
• The dialogs don't have horizontal padding and they are taking whole screen width , I think its configuration fault

TODO :

• [x] Convert LocalDate & LocalTime to kotlin , Use expected classes provide the same functionality
• [ ] Consider using a date time library like kotlinx-datetime which is kotlin multiplatform and also provides interop functions with java date time api
• [ ] Ok this is more of a suggestion , DatePicker And Time Picker should not depend on core module , One should be able to create their own dialogs or even put them inside bottom sheet but since you are using dialogs no one can do that

[PranavMaganti]

Thanks for working on this. I'll try and take a look at it over the next couple weeks.

[Syer10]

I did my own port of Compose Material Dialogs to Compose Multiplatform https://github.com/Syer10/compose-material-dialogs Feel free to take from it as well.

I have ported version 0.20.0 of Accompanist to Compose Multiplatform(future versions are blocked because of the Snapper library) and use it in this port.

I only care for Jvm variants so I didnt use other multiplatform things like porting LocalDate to Kotlin.

I did use some stuff from @wakaztahir's fork because he did do some heavy lifting that I felt was worth it.

I havent tested anything yet, its a straght port that I will be using in my Desktop/to-be-android application, so hopefully nothing is broken.

[wakaztahir]

have you published accompanist , I would like to use it...

[Syer10]

Yep, just click one of the links in the readme and it will show you the implementation instructions

[wakaztahir]

I cannot access any class in the library in my commonMain , I can access them in Android & in my jvm but not in my commonMain

[Syer10]

Currently my Accompanist and material dialog forks use a shared Jvm main, so nothing is exposed to common. My application does the same so I haven't put in the work to use expect/actual in them. I'll look into it but currently my forks fit my needs so no promises.

[Syer10]

New update out for the multiplatform dialogs, fixed many bugs on desktop and added support for icons and window titles

[wakaztahir]

Thanks but I already made a port of accompanist multiplatform !

Link

[Syer10]

Got some time today to work on my forks, Accompanist and Compose Material Dialogs(other than DateTime) use CommonMain. I am waiting on LocalTime support in KotlinX-datetime to port the datetime module

[NorbertSandor]

@Syer10, could you please update your fork to the latest 0.7.0 version?

[Syer10]

@Syer10, could you please update your fork to the latest 0.7.0 version?

Done 👍

[DatL4g]

@Syer10 a new stable multiplatform compose Version 1.2.0 has been released. Can you please update your libraries?

[Syer10]

I guess I could when I have time. Its not really priority since I already had them using the 1.2.0 alpha builds and they work fine on my 1.2.0 application.