search

PranavTrip / WeatherReact

A weather app made using React, React Hooks, Bootstrap and many more technologies.
4 stars 6 forks source link

Add Footer to the Weather React App. #7

Closed omkar342 closed 2 years ago

omkar342 commented 2 years ago

Hi @PranavTrip, I would like to add a responsive footer to your project. I can also add your Social Media handle links in the footer. If you have any other idea of adding anything to the footer plz share that with me & I would be really grateful if you can assign this to me.

PranavTrip commented 2 years ago

Hey @omkar342 instead of a footer I am thinking of adding a dynamic background image according to the weather of that particular city. Like if the weather is sunny the background image must be changed to sun. If you have any doubt feel free to ask.

iamvaiibhav19 commented 2 years ago

hi @PranavTrip I would like to contribute to your weather app as I have build one previously. So do you want footer or dynamic background image?

iamvaiibhav19 commented 2 years ago

I can make both!

PranavTrip commented 2 years ago

hi @PranavTrip I would like to contribute to your weather app as I have build one previously. So do you want footer or dynamic background image?

Okay @iamvaiibhav19 you can create dynamic image background while @omkar342 will make a footer I think this will help you both. Please co-operate.

iamvaiibhav19 commented 2 years ago

@PranavTrip Not an issue! I will make dynamic image background.

PranavTrip commented 2 years ago

@PranavTrip Not an issue! I will make dynamic image background.

Okay @iamvaiibhav19 already assigned go ahead.

iamvaiibhav19 commented 2 years ago

@PranavTrip Just gone through your weather app. As I was trying to give input of any city, as soon as i enter first letter in the search box it gets store in the state 'search' which you have made of searchbox and it starts fetching data for it so it is giving error and is not user friendly. So can i make a button named search which will take whole input from search box and then only it will fetch so it wont be give any error. This is because I am trying to access image icon from the api you are fetching. so do let me know

PranavTrip commented 2 years ago

@PranavTrip Just gone through your weather app. As I was trying to give input of any city, as soon as i enter first letter in the search box it gets store in the state 'search' which you have made of searchbox and it starts fetching data for it so it is giving error and is not user friendly. So can i make a button named search which will take whole input from search box and then only it will fetch so it wont be give any error. This is because I am trying to access image icon from the api you are fetching. so do let me know

I will create a new issue and assign it to you. Is it okay ?

iamvaiibhav19 commented 2 years ago

@PranavTrip Okay.

PranavTrip commented 2 years ago

@PranavTrip Just gone through your weather app. As I was trying to give input of any city, as soon as i enter first letter in the search box it gets store in the state 'search' which you have made of searchbox and it starts fetching data for it so it is giving error and is not user friendly. So can i make a button named search which will take whole input from search box and then only it will fetch so it wont be give any error. This is because I am trying to access image icon from the api you are fetching. so do let me know

Created a separate issue for this problem please work on that. Issue #8 . I am assigning the issue #8 to you and leaving this issue for @omkar342 .

omkar342 commented 2 years ago

Ok, I am ready to work on this issue.

PranavTrip commented 2 years ago

Ok, I am ready to work on this issue.

Okay @omkar342 already assigned this to you please go ahead