Pranavkhade / PACKMAN

PACKMAN: PACKing and Motion ANalysis
Other
33 stars 7 forks source link

More server fixes #19

Closed njbooher closed 3 years ago

njbooher commented 3 years ago

Fixes:

Pranavkhade commented 3 years ago

Can you please brief me about the deleted files?

Also, Sorry for not adding import inside the if condition.

njbooher commented 3 years ago

The deleted files are the contents of the build, dist, and py_packman.egg-info directories. These directories are automatically generated by setuptools when you run python setup.py install or similar. They don't need to be stored in the repository.

The build directory being in the repository is causing an issue when the server installs the package in a virtual environment. python setup.py install sees that there's already a build directory and installs the files from it rather than from the packman directory. This is a problem because the build directory in the directory is currently out of date.

The easiest way to resolve this is to not store the build directory in the repository at all.

Pranavkhade commented 3 years ago

Thank you. Will this affect the twine upload? Because every time I upload a new version on PyPI, it requires me to match all the previous versions with the existing ones on the PyPI.

If this will not create any problems with PyPI (pip), I will go ahead with the merge.

njbooher commented 3 years ago

I don't think it will affect it. Make a new release after merging to test.