Pranavnk15 / Todo-List

✅ Todo-List: Stay Organized and Productive! Create, manage, and conquer your tasks effortlessly. Stay on top of your to-dos or discover new tasks to add to your list.
https://frail-plum-stingray.cyclic.app/
MIT License
10 stars 20 forks source link

Add github workflows #16

Closed Pranavnk15 closed 11 months ago

Pranavnk15 commented 11 months ago

Try adding a GitHub workflow for auto commenting, on raising a issue, or performing test on pull request

Rachit1313 commented 11 months ago

Hi Pranav, I would like to work towards implementing ESlint script in the code and a workflow to parse this through esLint to check for any errors in PR.

Pranavnk15 commented 11 months ago

Hi Pranav, I would like to work towards implementing ESlint script in the code and a workflow to parse this through esLint to check for any errors in PR.

Hi rachit any update further??

Rachit1313 commented 11 months ago

Hi Pranav, I would like to work towards implementing ESlint script in the code and a workflow to parse this through esLint to check for any errors in PR.

Hi rachit any update further??

Hey, Sorry Pranav. I just got a bit busy. I'll push the PR today.

Rachit1313 commented 11 months ago

@Pranavnk15 , Sorry for the delay. I just created a PR for this. Could you please review and let me know if any changes are required?

Rachit1313 commented 11 months ago

I think I made some issue in fixing the conflict. Could you revert the merge if possible?

Pranavnk15 commented 11 months ago

I think I made some issue in fixing the conflict. Could you revert the merge if possible?

I guess I have reverted it please check

Rachit1313 commented 11 months ago

Yes, you created a PR. Could you please merge that one.

Pranavnk15 commented 11 months ago

yep 1 sec

Pranavnk15 commented 11 months ago

done

Pranavnk15 commented 11 months ago

I guess there's some error with it, cause, as you can see the latest PR, its not functioning properly, while installing dependecies and checking

Rachit1313 commented 11 months ago

yup What happened is that I forked your repo to work on it and while I was working on it. There were another commits which changes package-lock.json. I think it would be better if we take the code back to https://github.com/Pranavnk15/Todo-List/commit/cc4fca335e4cfc899e88a70c04f94e56d643496e

and then I can add the feature again after syncing my fork.

On Mon, Oct 9, 2023 at 1:54 PM Pranav Khandagale @.***> wrote:

I guess there's some error with it, cause, as you can see the latest PR, its not functioning properly, while installing dependecies and checking

— Reply to this email directly, view it on GitHub https://github.com/Pranavnk15/Todo-List/issues/16#issuecomment-1753422685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN7BZU2GK5E7KDO4ZMLZFK3X6Q24RAVCNFSM6AAAAAA5W7GVXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGQZDENRYGU . You are receiving this because you were assigned.Message ID: @.***>

Rachit1313 commented 11 months ago

After you are done with this step. Could you reopen this issue and the PR.

Pranavnk15 commented 11 months ago

so should I revert that commit too?

Rachit1313 commented 11 months ago

I think you're good. just open a #24

Rachit1313 commented 11 months ago

Kindly refer to #27

Pranavnk15 commented 11 months ago

ya done

Pranavnk15 commented 11 months ago

Thanks for your contribution