Closed pooranjoyb closed 1 year ago
@pooranjoyb the project is not working with the changes you have made.
It is important to check whether the core project is working or not before raising the PR, when I go seat booking it is not showing the option to book the seat, no data selecting option.
I have mentored various projects, and I always review the changes and make sure the project is in working condition. I just do not merge any PR, by looking at fancy things.
I am closing this PR since it is not acceptable from any contributor side, it is my last warning
Structuring is something but working on the project is more important!!
Okay, so this is the thing, you ask me to work on something, I do work on that, and you close the PR without even requesting for changes.
I don't contribute unnecessarily for the sake of contributions; I do work for what I love to. I saw you project is quite good, but the structuring is totally messed up. So, I raised an issue to fix that. And this is how you publicly respond to someone's work.
If I raise a PR, you can always ask for a review and request the changes. It is not like you'll blame me for some issues by saying stuffs like fancy things and all. That is purely unprofessional and obviously not expected from mentors.
.py
files were scattered across the directory for no reason. .html
file has been used. main.py
files, I don't know why.The reason is that you neither you have written a proper documentation of how the project is working nor how it supposed to work. There are some random .txt
files across the directory without even mentioning why they exist.
This is not how you work as a mentor, obviously not by talking this rude. And you talk about warning, well, how many times have you guided me through? If you don't want someone to work on something, then don't ask them to. And if someone's doing something, you could atleast show some respect. @Pranjal360Agarwal
@pooranjoyb Okay, I totally understand. I always have respect for your work, I have gone through all of your work, and I note that it takes time for the proper structure of any project. For words, yeah I agree maybe I should not go through this way. Or at least I should give suggestions to guide.
On bus booking page, might be there are some files which are not properly linked, you can just recheck it and I assure for your efforts, it will have of Level-3 double from this.
Please check the Working Video & lemme know if some changes are to be made.
Video-Tue-May-30-2023-13-44-44.webm
@Pranjal360Agarwal
Description
With this PR merged, the entire project is will be migrated to Python Module
Closes #131
Workflow
bus-booking-system
directory for the module.assets
directory that containsPresentations
&images
.html
files in theweb
directory inside the modulepython -m bus-booking-system
Would be glad if you'd merge this PR @Pranjal360Agarwal 😃 👍