search

PranshulGG / WeatherMaster

A Weather app for android 🌦🌞☔
GNU General Public License v3.0
530 stars 11 forks source link

Animation Full Frame #110

Open sarojpanda44 opened 3 days ago

sarojpanda44 commented 3 days ago

UI/UX Issue

The cloud animation doesn't fill up the full top frame. It looks better with full frame animation like in Google weather forecast. Screenshots attached. Thanks 👍

Screenshot_20241111-214753 Screenshot_20241111-214835

Additional Context

Any additional context, such as suggestions for improvement.

PranshulGG commented 3 days ago

The animation is gonna get cut off at the status bar anyway, which doesn’t look great. Also, the animation I’m using isn’t really big enough to fill up the card and top header, but I'm thinking to make the app edge to edge so yea I might consider.

sarojpanda44 commented 2 days ago

Not sure if edge to edge is required. But it is more about animations being in the backgroud of the search box, instead of starting from below.

PranshulGG commented 2 days ago

The reason is the top ‘search bar’ and bottom card are two different elements, so I can’t overlay the animation. Like, in Google’s, when you scroll down, the search bar doesn’t stick to the top ‘cause it’s the same element. But in mine, it does stick, so I’d have to remake the whole main card and search bar to make it work.

sarojpanda44 commented 2 days ago

Understood. Trading off with one or the other features 😄 But keep in mind if it's possible in any way then it would be amazing 😊

PranshulGG commented 2 days ago

Understood. Trading off with one or the other features 😄 But keep in mind if it's possible in any way then it would be amazing 😊

If it’s easy to implement, you might see it in the next update