PranshulGG / WeatherMaster

A Weather app for android ๐ŸŒฆ๐ŸŒžโ˜”
MIT License
122 stars 1 forks source link

Suggestions #16

Open ak47m91 opened 2 weeks ago

ak47m91 commented 2 weeks ago

Hello again, sorry to be a burden , but I have some suggestions First, I suggest moving the moderate risk and fair to the right because there is dead space there and it helps saving space

Screenshot_20240830_144153_WeatherMaster.jpg

Then you could use some of the shapes of the new Google Weather app for the visibility, humidity, wind and pressure

Screenshot_20240830_150055_WeatherMaster.jpg

Screenshot_20240830_145011_Pixel Weather.jpg

That's it , hope you understand my design choices!๐Ÿ˜€

Originally posted by @ak47m91 in https://github.com/PranshulGG/WeatherMaster/issues/11#issuecomment-2321014215

PranshulGG commented 2 weeks ago

Yeah, sure! I was thinking of changing the UI to look more like the new Pixel weather app. I'll include these changes in the next version. If you have any other suggestions, feel free to open an issue. Thanks for the feedback!

ak47m91 commented 2 weeks ago

Well , I was thinking of replacing the radar with the open weather map one. It's not useful for viewing the past precipitation.

PranshulGG commented 2 weeks ago

Well , I was thinking of replacing the radar with the open weather map one. It's not useful for viewing the past precipitation.

Yeah, I'm looking for a better radar that can provide future forecasts. Are you talking about the OpenWeatherMap radar from openweathermap.org/weathermap

ak47m91 commented 2 weeks ago

Yes , this one, I think it is quite reliable , and if you can , maybe you could keep them both

ak47m91 commented 2 weeks ago

Actually , after further examination, open weather map has like the same algorithms like rain viewer for global precipitation. You can only see in the past

ak47m91 commented 2 weeks ago

But still, I think it has more features than the standard rain viewer, but best If you can keep them both

PranshulGG commented 2 weeks ago

"Yeah, but the OpenWeather API doesn't provide any timestamps, so it's just a fixed-time radar image

ak47m91 commented 2 weeks ago

So you cannot see the future rain?

PranshulGG commented 2 weeks ago

So you cannot see the future rain?

Right, it only provides the latest radar image

ak47m91 commented 2 weeks ago

Well, i dont know what to say, maybe open meteo has one?

PranshulGG commented 2 weeks ago

Well, i dont know what to say, maybe open meteo has one?

I'll figure something out, but no, Open-Meteo doesn't provide any radar data

ak47m91 commented 2 weeks ago

Okay, I have one more suggestion, or two. First one would be that you maybe should the clothes recommendation above the hourly forecast because it is a hidden gemScreenshot_20240830_164823_WeatherMaster.jpg

ak47m91 commented 2 weeks ago

And you could add all the frog pictures, and maybe design a widget like thisScreenshot_20240830_164928_WeatherMaster.jpg

PranshulGG commented 2 weeks ago

I'll move the clothes container up, and widgets are next on my list to work on. So, yeah

PranshulGG commented 2 weeks ago

and what do you mean by all the frog pictures?

ak47m91 commented 2 weeks ago

Have you added all?

PranshulGG commented 2 weeks ago

Have you added all?

18

ak47m91 commented 2 weeks ago

What?

PranshulGG commented 2 weeks ago

What?

Currently, the app has a total of 18 frog images

ak47m91 commented 2 weeks ago

Ahh, sorry for the misunderstanding

ak47m91 commented 2 weeks ago

But how many are there in total because gemini told me there is an unknown number

PranshulGG commented 2 weeks ago

There are more than 25

ak47m91 commented 2 weeks ago

I understand, when is the update coming๐Ÿ˜ƒ

PranshulGG commented 2 weeks ago

I understand, when is the update coming๐Ÿ˜ƒ

Maybe tomorrow

ak47m91 commented 2 weeks ago

Perfect

ak47m91 commented 2 weeks ago

Just got the update , it looks very nice

ak47m91 commented 2 weeks ago

Okay , some more suggestions... So, you could center the summary of the day , and when it exceeds the row , you can return to the left alligment Screenshot_20240830_231228_WeatherMaster.jpg

Then you could add accuweather or weather api as weather provider

PranshulGG commented 2 weeks ago

Adding other weather providers doesn't add much value since the app already has OpenWeather, Open-Meteo, and Visual Crossing. Adding AccuWeather or WeatherAPI.com wouldn't provide significantly new data, as the app already covers most of it.

ak47m91 commented 2 weeks ago

You added open meteo? Thats great , but I was saying to add them because sometimes they arent very accurate

PranshulGG commented 2 weeks ago

You added open meteo? Thats great , but I was saying to add them because sometimes they arent very accurate

WeatherAPI.com only provides 3 days of weather data, and AccuWeather only allows 50 calls per day, which is not enough.

ak47m91 commented 2 weeks ago

Well, I was thinking of accuweather because breezy weather has accuweather , and it is still a foss app?

ak47m91 commented 2 weeks ago

Screenshot_20240831_122818_Breezy Weather.jpg

PranshulGG commented 2 weeks ago

Well, I don't really know what they are doing, but if I go to the AccuWeather website, this is what the free plan offers:

Daily Forecast: 5 days Hourly Forecast: 12 hours Current Conditions and only 50 calls a day That's all

ak47m91 commented 2 weeks ago

Idk, maybe try asking the dev?

PranshulGG commented 2 weeks ago

Idk, maybe try asking the dev?

Yeah, I'll mail them

ak47m91 commented 2 weeks ago

And you could maybe try to combine the main data from weather api with the 8 day forecast from open weather map

PranshulGG commented 2 weeks ago

And you could maybe try to combine the main data from weather api with the 8 day forecast from open weather map

Or maybe I'll just use Open-Meteo and WeatherAPI and remove OpenWeatherMap and the others

PranshulGG commented 2 weeks ago

And this is the current API limit of the app: 950,400

ak47m91 commented 2 weeks ago

And you could maybe try to combine the main data from weather api with the 8 day forecast from open weather map

Or maybe I'll just use Open-Meteo and WeatherAPI and remove OpenWeatherMap and the others

No, don't remove openweather map, keep it, or does it cost more?

ak47m91 commented 2 weeks ago

And If you want I could help you with the translation to romainian, btw where are you from?

PranshulGG commented 2 weeks ago

And If you want I could help you with the translation to romainian, btw where are you from?

I'm from India, and the translations I'm working on need to ensure the app actually supports different languages. Right now, it's hard-coded in English, so I have to modify a lot of things, which is going to take some time

PranshulGG commented 2 weeks ago

And also widgets

ak47m91 commented 2 weeks ago

Ok, and now , in the end , did the dev of breezy weather told you smth about accuweather?

PranshulGG commented 2 weeks ago

Ok, and now , in the end , did the dev of breezy weather told you smth about accuweather?

I did email them, but I haven't received a response yet.

ak47m91 commented 2 weeks ago

And you could add something like a weather insight that is scrollable, smth like I did here and that is present in the one ui weather app Screenshot_20240831_160001_WeatherMaster.jpg

PranshulGG commented 2 weeks ago

Yeah, it's a cool small detail, so sure

On Sat, Aug 31, 2024, 6:33 PM ak47m91 @.***> wrote:

And you could add something like a weather insight that is scrollable, smth like I did hereScreenshot_20240831_160001_WeatherMaster.jpg (view on web) https://github.com/user-attachments/assets/2a4895e2-d44f-4a61-9c10-ad38fb64e535

โ€” Reply to this email directly, view it on GitHub https://github.com/PranshulGG/WeatherMaster/issues/16#issuecomment-2322891253, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAEKYYGCBTWIXKRX5NSCSILZUG5KTAVCNFSM6AAAAABNMNBHZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHA4TCMRVGM . You are receiving this because you commented.Message ID: @.***>

ak47m91 commented 2 weeks ago

Ok, so In the end, which providers are you adding? Also one more provider I am recommending is Met Norway

PranshulGG commented 2 weeks ago

Yea Met norway and weatherapi

PranshulGG commented 2 weeks ago

And do you have any other suggestions for the type of weather insights I should add? Like temperature trends, etc.

ak47m91 commented 2 weeks ago

If the temperature is increasing or decreasing over the span of a couple of days, the sunset or the sunrise in an hour ,for example.... Sunset in an 1 hour , or in 30 minutes, but it shouldn't exceed 1 hour, the amount of rain , the weather for tommorow with the data for clouds, etc like thisScreenshot_20240831_171819_WeatherMaster.jpg

If there is a storm , hurricane , blizzard, or thunderstorm, show an insight, idk what to say more