PranshulGG / WeatherMaster

A Weather app for android 🌦🌞☔
MIT License
133 stars 1 forks source link

wrong unit in textual report #28

Closed Der-Flip closed 1 week ago

Der-Flip commented 1 week ago

hi, great app, beautifully designed.

In the text report the precipitation unit doesn't seem to be affected by the selected unit in the settings; I have it set to mm, but it's still being reported in inches. screenshot for clarification

while we're at it, maybe ad the unit to the degrees (° isn't really the unit. so probably best to add the C or F).

PranshulGG commented 1 week ago

I know about this issue—I forgot to add a function to convert it to mm, as it returns in inches by default. This will get fixed in the next version.

As for the ° symbol (without °C or °F), I chose that because it looks better, and sometimes the text alignment gets messed up. I don't think it's necessary since you already know which setting you have applied.