search

PranshulGG / WeatherMaster

A Weather app for android 🌦🌞☔
GNU General Public License v3.0
392 stars 8 forks source link

Themed Icon Support #57

Closed vilijur closed 2 weeks ago

vilijur commented 2 weeks ago

I've been trying this app out for a bit now and I've enjoyed it quite a bit. However, something i noticed was the lack of support for themed icons. Here's an image of what I mean:

image

Compared to some other apps, this app's icon sticks out like a sore thumb. While this isn't a massive deal, it's still something that would be nice to resolve.

Interestingly enough, while poking around the source code, I noticed that the square icon did have this support, but the round icon (the one used on my Pixel phone) didn't. Though, the icon used does seem a little.. basic...

image

I have gone ahead and took a looksee at what it would look like if the rounded icon did have the same monochrome icon as the square icon, which looks something like this:

image

Now I'm not an experienced Android developer by any means (though I am interested in getting into Android development) so please excuse my ignorance, but I assume this is pretty easy to do using the app's main icon instead of the more basic looking sun.

In fact, I tried it with the foreground icon as the monochrome icon and... image ...yeah, this is going to need to be modified a bit.

With all that being said, I kinda know my way around image editing software so I could probably make a proof of concept monochrome icon in a bit. As this is mostly just a thing I want, I don't mind taking care of it by myself if you'll allow me to. Up to you though!

PranshulGG commented 2 weeks ago

Yeah, I added that icon in a hurry, but it’s been changed now and will be in the next version. I’ll go ahead and close this since it’s a duplicate issue.