I wrote this quick explanation of my thoughts on slack. The sentiment was that it was worth expanding to a blogpost:
Depends on what the PR is for. I am beginning to distinguish lingually between “Pull Request” and “Merge Request”. A PR is a request for someone to look at your code (online or “pulling" the branch if needed). A PR can be on very unfinished code and is a good tool for collaboration. This might still make perfect sense even in a Pip world. On the other hand, a Merge Request is the more classical sense indicating “I have this code, I really believe it is done done, and maybe we have already discussed it at length." In a fork-model this would indicate "Would you please accept it in your repo”. In a normal central repo model, this would more be a role-based thing or motivated by a security policy? .
I wrote this quick explanation of my thoughts on slack. The sentiment was that it was worth expanding to a blogpost:
Depends on what the PR is for. I am beginning to distinguish lingually between “Pull Request” and “Merge Request”. A PR is a request for someone to look at your code (online or “pulling" the branch if needed). A PR can be on very unfinished code and is a good tool for collaboration. This might still make perfect sense even in a Pip world. On the other hand, a Merge Request is the more classical sense indicating “I have this code, I really believe it is done done, and maybe we have already discussed it at length." In a fork-model this would indicate "Would you please accept it in your repo”. In a normal central repo model, this would more be a role-based thing or motivated by a security policy? .