search

Praqma / pretested-integration-plugin

A generic pretest commit plugin for Jenkins CI
MIT License
7 stars 14 forks source link

Only allow branch heads to be integrated #13

Open lakruzz opened 8 years ago

lakruzz commented 8 years ago

Trello card

The git plugin, which handles checkout and parses the pretested integration plugin some build and git data sometimes only resolves a git SHA.

We should check that SHA is a branch head and that the branch correspond to our branch pattern. Remember to ask for branch head, not only which branch the commit belongs to.

We should only integrate complete branches - that is where we either get a SHA that resolves to a branch head, or get a branch name (that automatically resolves to a SHA that is branch head.

lakruzz commented 8 years ago

@MadsNielsen:

It can happen even when using branches. Given the wrong timing (especially cases where the polling interval on the Jenkins job is longer than the build time), you can end up deleting commits that should have been tested,

We haven't seen a case of it yet...but the consequence of this one can be quite dramatic..