search

Praqma / pretested-integration-plugin

A generic pretest commit plugin for Jenkins CI
MIT License
7 stars 14 forks source link

Pretested checkout should fail if git is configured wrong #135

Open zlepper opened 6 years ago

zlepper commented 6 years ago

When Jenkins does the checkout so it can merge ready branches into the integration branch, it attempts to do a new commit. However if git credentials has not been configured on the server, this commit will fail with a message that tells the user to configure git user.name and user.email.

If this happens jenkins still proceed with the rest of the pipeline, instead of actually marking the stage failed. The rest of the pipeline will run successfully, until it attempts to push things back to git. Here Pretested will complain [PREINT] Build result not satisfied - skipped post-build step..

The main problem with this is that it can be extremely difficult to debug, as none of the previous stages apparently didn't fail, you have to read the log pretty closely to actually find the issue.

bicschneider commented 4 years ago

@zlepper .. Thanks for the input .. Is this still relevant?

zlepper commented 4 years ago

Honestly i have no clue.

I used Pretested as part of a school course with one of your consultants, and found this issue, and was told to report it here. So for my sake you can close it, I don't have any stakes in it :)