search

Praqma / pretested-integration-plugin

A generic pretest commit plugin for Jenkins CI
MIT License
7 stars 14 forks source link

Replace JGit Repository.getRef() with Repository.findRef() #140

Closed MarkEWaite closed 5 years ago

MarkEWaite commented 5 years ago

JGit 5.0 (or earlier) deprecated the Repository.getRef(String) method and replaced it with two methods, Repository.findRef(String) and Repository.exactRef(String).

JGit 5.2 removed the deprecated method.

Git client plugin 3.0 will bundle JGit 5.2 or later. Rather than risk runtime and compilation failures when using git client plugin 3.0 and later, switch from the deprecated methods to the new methods.

Without this change, this plugin will be broken with the release of git client plugin 3.0.

MarkEWaite commented 5 years ago

You may also want to push the source code of the latest release to the jenkinsci repository, since it seems to be one release behind the authoritative repository.

MarkEWaite commented 5 years ago

I assume someone has already adapted this change into the official repository. Whether they have or not, the release of git client plugin 3.0.0 in the next 1-2 weeks will break the plugin if it has not been updated to include this change.