Goal: Remove the NOT_BUILT scenario

Praqma / pretested-integration-plugin

A generic pretest commit plugin for Jenkins CI

MIT License

7 stars 14 forks source link

Goal: Remove the NOT_BUILT scenario #144

Open MadsNielsen opened 4 years ago

MadsNielsen commented 4 years ago

Subtasks

[x] No branch should return latest integration branch (#143)
[ ] Triggered branch is the same as integration branch
[ ] Triggered branch is behind the integration branch
[ ] Triggered branch is behind the integration branch should be configurable (Optional)

bicschneider commented 4 years ago

NKJensen commented 4 years ago

Perhaps consider to write "Missing branch" in stead of "No branch" ? The "Triggered branch is the same as integration branch" is IMHO a null-operation, just return master for building.

NKJensen commented 4 years ago

"Triggered branch is behind the integration branch" - this could be halted in the pre-receive hook. It would be OK to return "master" in case someone sends in a "historical" commit on a ready-branch

NKJensen commented 4 years ago

I mean - don't make an option for "Triggered branch is behind the integration branch" - if it is a problem in your organization, use the pre-receive hook. It will be much easier for new developers to understand at that time in the process, I think