Praqma / tracey-jenkins-trigger-plugin

Jenkins RabbitMQ trigger for Tracey project
MIT License
0 stars 2 forks source link

Rearrange order of exchange type and host as well as making their fields width the same #51

Closed Andrey9kin closed 8 years ago

Andrey9kin commented 8 years ago

Definition of Done for the pull request

Please use squash merge by default unless you have a very good reason not to do so

Andrey9kin commented 8 years ago

@MadsNielsen I changed exchange type drop down the list to doFill. However, I agree with @alexsedova that it is clearer when you list options in the jelly file itself. The reason for the change is that jelly renders different fields width for those two types which look ugly. So have to align

MadsNielsen commented 8 years ago

@Andrey9kin Taht's alright, i was just curious as to why we were using Jelly. If you do it in jelly you've got more maintainence because you have to make sure your string values, matches your enums in code...for instance. For me it's just easier to use the ListBoxModel for those sorts of things.

Btw...i like the direction with all those options you're adding to the RabbitMQ trigger.

alexsedova commented 8 years ago

@MadsNielsen I tried to use ListBoxModel in doFillJenkinsMagicFunction but I fault to save exchangeType. We needed the fix asap and I went the fastest way to add static options to jelly form.