PrateekKumarSingh / AzViz

⚡ ☁ Azure Visualizer aka 'AzViz' : A #powershell module to automatically generate Azure resource topology diagrams by just typing a PowerShell cmdlet and passing the name of one or more Azure Resource groups
MIT License
597 stars 148 forks source link

Don't install dependencies when importing the module #23

Closed o-l-a-v closed 3 years ago

o-l-a-v commented 3 years ago

Please don't install dependencies when importing the module. This means that, even if you only installed the module to look at what commands Get-Command -Module 'AzViz' and paramters Get-Help -Name '<some-function>- -Parameter '*', AzViz will prompt to install Chocolatey and GraphViz.

Please move this to a function that other functions can use and trigger.

PrateekKumarSingh commented 3 years ago

@o-l-a-v Thank you for the feedback. This make sense!

I've already removed chocolatey installation of 'Graphviz' and marked it as a pre-req for this module to work in latest version. Which have to be installed explicitly.

I'll move the module installation to a function and call it when commands are running. TBD

PrateekKumarSingh commented 3 years ago

This has been fixed in recent commit to this repository.