search

PrathmeshSadake / unsplashy

An image gallery that fetches images from Unsplash API. It has some awesome features like searching for images and infinite scrolling in which images keeps on loading as the user scrolls.
https://unsplashy-prathmeshsadake.netlify.app
23 stars 16 forks source link

Route Validation #16

Closed Yourstruggle11 closed 2 years ago

Yourstruggle11 commented 2 years ago

Report Bug

There is no route validation.

If a user logs out and then goes to / home he is being given access to the home page again which should not be happen. instead of that he/she should be sent back to the login page

shub78910 commented 2 years ago

I can work on this, could you assign this to me?

Yourstruggle11 commented 2 years ago

@nawed2611 assign @shub78910 for this task

nawed2611 commented 2 years ago

Hi, Please check out this to write clear and descriptive issues and writing in GitHub Markdown.

Yourstruggle11 commented 2 years ago

@nawed2611 Yes, of course, but there was no instruction in this repo, so I wrote the issue in this way

roshanchatei commented 2 years ago

@nawed2611 I would like to work on this issue.

nawed2611 commented 2 years ago

Go ahead! @roshanchatei

roshanchatei commented 2 years ago

I have done route validation but why I am not able to push it it's showing that I don't have access, @nawed2611 can you please help me out?

unsplashy – Homepage js 3_31_2022 7_02_23 AM

nawed2611 commented 2 years ago

Hey @roshanchatei I believe you're trying to push directly to this repo. Did you clone your forked repo to the system? Try following this and let me know if you're getting any issues

roshanchatei commented 2 years ago

Hey @roshanchatei I believe you're trying to push directly to this repo. Did you clone your forked repo to the system? Try following this and let me know if you're getting any issues

thanks a lot, I have resolved this issue.