search

Praxxian / lava-flow

A Foundry VTT module that allows you to import your notes from Obsidian MD into Foundry journal entries.
MIT License
61 stars 9 forks source link

“please select one or more file” #9

Closed Superelmanu closed 2 years ago

Superelmanu commented 2 years ago

Hello, I'm at a lost. I tried to make it work, but Lava Flow keep asking me to pick a file. “please select one or more file” It doesn't seam to be able to pick any folder or see any files. What am I missing? I'm on v 0.13.18 of Obsidian and Version 9 - Build 238 of the foundry.

Best Manu

Praxxian commented 2 years ago

The folder picker hides files. Confirm in your native file browser that the folder you are selecting contains files.

You will want to make sure the field "Folder" at the bottom of the folder picker has the actual folder you want. Sometimes it opens up within a folder without that folder being selected, and you just need to go up one level and click the folder you want.

This really isn't custom code on my part. This is how the HTML input element works for folders.

For example, if the folder I want is called "vault" and it opens up in that folder, sometimes it is not selected at the bottom of the picker: image

Superelmanu commented 2 years ago

I have *.MD file in the Obsidian folder. The Obsidian folder is selected in the folder field. When I'm importing, it is still asking me “please select one or more file”.

I would love to use this add-on. Please help me out to understand what's going on?

Praxxian commented 2 years ago

What browser and OS are you using?

  1. Open your browser's console. (F12 for most browsers)
  2. Open the import dialog from the journal tab.
  3. Try importing the folder using the steps you have been using.

Do you receive any errors during this?

Superelmanu commented 2 years ago

I'm using the desktop application for the foundry.

Praxxian commented 2 years ago

The cool thing is that the desktop foundry does have a console accessible by pressing F12.

Superelmanu commented 2 years ago

FoundryVTT_Lava_flowC.zip

I uploaded a video of what is happening. Let me know if it's helpful?

Praxxian commented 2 years ago

Pretty helpful, although the developer tools on the right were set to Element not Console, so I could not see if you have any errors popping up during. Could you repeat those steps and just screenshot or copy+paste any errors in the console?

I have not ran into any issues with the desktop app, but for diagnostics, could you try accessing your instance through a browser. Start the app, then go to http://localhost:30000/ in your browser of choice and see if you can reproduce the issue. That port number might be different if you have changed that setting.

From the evidence so far, it looks like an empty folder, but you say there are files in there. Do you use a file sync service for your vault? I know some like google drive do a thing where the files are not actually present on your local storage until you try to access the file. Could be something where File Explorer shows files that are not really there? Or do you use symbolic links or anything out of the ordinary with your vault?

Superelmanu commented 2 years ago

So, I tried on the web browser, and it works perfectly.

Praxxian commented 2 years ago

Glad we at least have a workaround! It occurred to me that while I have tested v9 in browser on my hosted instance, all my local testing through the app has been through v8. I will try downloading the latest desktop version and see if I can reproduce it there.

Superelmanu commented 2 years ago

Let me know if I can help in way. Obsidian to foundry it's a dream come true. If you manage to import pictures to Foundry it will be AMAZING..

From: Praxxian @.***> Sent: Wednesday, January 5, 2022, 19:29 To: Praxxian/lava-flow Cc: Superelmanu; Author Subject: Re: [Praxxian/lava-flow] “please select one or more file” (Issue #9)

Glad we at least have a workaround! It occurred to me that while I have tested v9 in browser on my hosted instance, all my local testing through the app has been through v8. I will try downloading the latest desktop version and see if I can reproduce it there.

— Reply to this email directly, view it on GitHubhttps://github.com/Praxxian/lava-flow/issues/9#issuecomment-1006185775, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVFQTHSCCVPCEM5XJCIZORDUUTO6RANCNFSM5LKOI27A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

Praxxian commented 2 years ago

I was able to reproduce this using the desktop app. I think Foundry uses Electron, and there may be some sort of security feature to prevent getting full file paths or something like that. I will investigate more and see if this is something I can work around on my end.

Superelmanu commented 2 years ago

Thank you. You are onto something with this addon. Great work.

From: Praxxian @.> Sent: Wednesday, January 5, 2022 7:49:35 PM To: Praxxian/lava-flow @.> Cc: Superelmanu @.>; Author @.> Subject: Re: [Praxxian/lava-flow] “please select one or more file” (Issue #9)

I was able to reproduce this using the desktop app. I think Foundry uses Electron, and there may be some sort of security feature to prevent getting full file paths or something like that. I will investigate more and see if this is something I can work around on my end.

— Reply to this email directly, view it on GitHubhttps://github.com/Praxxian/lava-flow/issues/9#issuecomment-1006194913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVFQTHRCU6OLKXJACMMJUYTUUTRJ7ANCNFSM5LKOI27A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

Praxxian commented 2 years ago

So this is something that broke with the version of Electron that the desktop app was made with: https://github.com/electron/electron/issues/31663

It's fixed in v16 of Electron, but I think the way electron apps work is that all the libraries are all compiled in the exe, so there is not really a way to "upgrade" the Foundry app ourselves.

Unfortunately, this means that you have to use the workaround of using your browser for now.

Superelmanu commented 2 years ago

I can totally live with that. It may be interesting to explain the workaround on the Foundry add-on page for V9 users?

From: Praxxian @.> Sent: Thursday, January 6, 2022 12:25 To: Praxxian/lava-flow @.> Cc: Superelmanu @.>; Author @.> Subject: Re: [Praxxian/lava-flow] “please select one or more file” (Issue #9)

So this is something that broke with the version of Electron that the desktop app was made with: electron/electron#31663https://github.com/electron/electron/issues/31663

It's fixed in v16 of Electron, but I think the way electron apps work is that all the libraries are all compiled in the exe, so there is not really a way to "upgrade" the Foundry app ourselves.

Unfortunately, this means that you have to use the workaround of using your browser for now.

— Reply to this email directly, view it on GitHubhttps://github.com/Praxxian/lava-flow/issues/9#issuecomment-1006768741, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVFQTHQOVLXYJCF5RTTVINTUUXGB5ANCNFSM5LKOI27A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

Praxxian commented 2 years ago

I've updated the README to describe the workaround. Seeing if I can get any attention on the discord for this. Usually module-related stuff is not permitted in their bug report channel, but this is something that potentially impacts multiple modules.

Superelmanu commented 2 years ago

Did you think about the possibility of importing picture from the *.MD file into Obsidian? I don't even know if it's even possible. But it will be a big plus if possible.

From: Praxxian @.> Sent: Thursday, January 6, 2022 12:50 To: Praxxian/lava-flow @.> Cc: Superelmanu @.>; Author @.> Subject: Re: [Praxxian/lava-flow] “please select one or more file” (Issue #9)

I've updated the README to describe the workaround. Seeing if I can get any attention on the discord for this. Usually module-related stuff is not permitted in their bug report channel, but this is something that potentially impacts multiple modules.

— Reply to this email directly, view it on GitHubhttps://github.com/Praxxian/lava-flow/issues/9#issuecomment-1006791621, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVFQTHWHAOWETRASEHTDV5LUUXI57ANCNFSM5LKOI27A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

Praxxian commented 2 years ago

Yeah one thing I need to do is learn more about Foundry's API for S3 storage. The user should be able to select either local or S3 storage.