PrayTeam / scriptured-prayer

GNU Affero General Public License v3.0
1 stars 0 forks source link

[BUG] Long scriptures bleed #106

Closed follindown closed 1 month ago

follindown commented 8 months ago

Describe the bug When the scripture is long it bleeds into the _ that tells where you are in the deck. When we do add in instructions this will become a problem on more cards than it currently affects.

To Reproduce Steps to reproduce the behavior: For instance go to "I can trade in treasures on earth for ones that last by giving" in the Promises of God deck on your cell phone.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

asherlloyd commented 5 months ago

Adding a screenshot of the defect for more information:

image

I'm not keen on the current slide markers (visually: _). It looks especially silly in circumstances where there are lots of slides - as in the shared screenshot. @kenancasey if you're onboard, let's troubleshoot other designs that could work here.

kenancasey commented 5 months ago

We had a PR that swapped out these markers for numbers e.g., 13/45 that I thought improved the UI. What do you think about that approach?

asherlloyd commented 5 months ago

@kenancasey I think that would work just fine for now. I'm going to submit a separate MR for it, however.