Feat/home faq - Githubissues

PrayTeam / scriptured-prayer

GNU Affero General Public License v3.0

1 stars 0 forks source link

Feat/home faq #112

Closed sflowers51 closed 3 weeks ago

sflowers51 commented 2 months ago

implemented home faq section, .gitignore updated

Description

implemented home faq section of the home page as well as made changes to .gitignore as requested by Kenan

Reason

Home faq section needs to be implemented and conflicts with previous pull requests require changes to .gitignore

How this has been tested

Tested window at three different widths - full screen, medium, mobile width- to ensure the faq section responds appropriately

Types of changes

[x] New feature (adds functionality)
[ ] Bug fix (fixes an issue)
[ ] Breaking changes (causes defects to existing pieces)

Screenshots

Checklist:

[x] I have read and complied with the CONTRIBUTING document
[x] The changes I've made follow the existing code style and formatting requirements
[ ] My changes require updates to the documentation, which I have modified accordingly

SeanJaniec commented 2 months ago

First, Great Job Sam. However, for me, it's too crowded. I don't like how the first faq is already open. Additionally, I believe there are too many FAQs on display, can hide some them and give an option to "display more FAQs." More vertical margin between the FAQs would help with the crowded look. Again, I like the overall look and simplicity, but I think some small adjustments would allow this component to better fit the aesthetic of scriptured prayer.