PrayTeam / scriptured-prayer

GNU Affero General Public License v3.0
1 stars 0 forks source link

Evaluate Reactivated #17

Closed kenancasey closed 6 months ago

kenancasey commented 6 months ago

This looks very relevant and helpful to use. https://www.reactivated.io/

Thoughts @asherlloyd @Soyokaze-42 ?

asherlloyd commented 6 months ago

I like this. It appears to simplify the configuration needed for React SSR. If we go with this package, it looks like we'd leverage the documentation for adding to existing projects. @Soyokaze-42 @benjoeclark interested to hear your thoughts?

benjoeclark commented 6 months ago

I'm not going to be much help in the React selection. I hope to learn from it but I'm still going through the Django tutorials getting up to speed.

Soyokaze-42 commented 6 months ago

This is opinionated to the point they don't like most of what I have already done. They really want us to use nix (which is a hard pass for me because it says you have to disable SELinux to use it). They also want to use docker and fly.io. Nothing wrong with docker. I don't know anything about fly.io, but their troubleshooting guide says new deployments are flaky, but solid after that. Using it in an existing project does look doable, but we have to kick the tires a bit.

They have unspecified features that require Django 4.0 which has lapsed out of extended support since April. The similarly required Python version is 3.9 which will break some of the existing code if we have to downgrade from 3.12. Not insurmountable, but not great. Performance will also likely suffer.

Did anyone put it in the existing app to see if it breaks anything?

kenancasey commented 6 months ago

That seems like enough reasons to skip on this one to me.

asherlloyd commented 6 months ago

I agree. From our discussion on 12/19 - we're not limited to using this for React + Django. @kenancasey we can probably close this.