search

PrayTeam / scriptured-prayer

GNU Affero General Public License v3.0
1 stars 0 forks source link

Allow FHU students to work on the project #43

Closed kenancasey closed 8 months ago

kenancasey commented 10 months ago

I'd like to use Scriptured Prayer in my Capstone course as our course project. Can we discuss allowing FHU students to work on this project, specifically v2 (custom decks/cards).

Pros:

Cons:

AC:

kenancasey commented 10 months ago

Thoughts? @follindown @Soyokaze-42 @asherlloyd @benjoeclark @Kelly22693

follindown commented 10 months ago

I am always open to students getting the benefit of learning from you guys. I also welcome their suggestions b/c they will see things from a different perspective. But ultimately it is probably up to you programmers. Will this make your lives easier or harder?

On Tue, Jan 16, 2024 at 11:08 AM Kenan Casey @.***> wrote:

Thoughts? @follindown https://github.com/follindown @Soyokaze-42 https://github.com/Soyokaze-42 @asherlloyd https://github.com/asherlloyd @benjoeclark https://github.com/benjoeclark @Kelly22693 https://github.com/Kelly22693

— Reply to this email directly, view it on GitHub https://github.com/PrayTeam/scriptured-prayer/issues/43#issuecomment-1894162033, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEXUS3QCGG6QM33Q7KHT2W3YO2X2VAVCNFSM6AAAAABB5CWQHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGE3DEMBTGM . You are receiving this because you were mentioned.Message ID: @.***>

kenancasey commented 10 months ago

Seeing no objections I'm planning to move forward with this plan to use FHU students as developers and designers on this project. Any more discussion before I close this issue?

Soyokaze-42 commented 10 months ago

I would like to talk about how this might work first. We don't have any guard rails up in the repo, so I'm not comfortable giving them access to the repo just yet. Are you thinking you will fork the repo and submit a pull request from the FHU fork when it is ready?

follindown commented 10 months ago

I have a question. If we use Freed students does Freed then own the website or its content in some way?

kenancasey commented 10 months ago

Good questions. Can I call you today to chat? Or setup a group call if @asherlloyd wants to join.

asherlloyd commented 10 months ago

I could also see students as being maintainers rather than building the initial "v1" version. The difficulty with simply adding students to the project as it stands would be allocation. Since our group is fairly tight-knit, we have a general understanding of how the work is split-up. But this might become more nebulous as the task force grows, especially since students will already have a myriad of commitments outside of the app.

asherlloyd commented 10 months ago

Another option might be to have students perform acceptance testing on v1...just spit balling :)

kenancasey commented 10 months ago

My vision was very much in keeping v1 as ours (the PrayTeam) and focusing on v2 with my students. I'd like to have a couple weeks to bring them up to speed AND have a couple weeks to finish the MVP. I completely support restricting student access to the repo (perhaps just read-only or fork-only) until we're ready to start on v2.

Also, does protecting main and restricting who can review give us the protection we want? I'd love to allow them to make a branch and start experimenting with tiny issues to get a feel for the project and the workflow.

Soyokaze-42 commented 10 months ago

We'd have to pay for github if we want to protect main. That is also not enough IMO. I would want a decent amount of automated testing in place so they don't accidentally break things and we don't have to keep fixing mistakes.

If you fork it, the pull request could essentially be your finalized contribution that you have already reviewed to cut the cruft before we see it.

kenancasey commented 10 months ago

Is it worth it to move to the FHU org?

What's the cost?

follindown commented 10 months ago

What does that mean?

On Thu, Jan 18, 2024 at 12:05 PM Kenan Casey @.***> wrote:

Is it worth it to move to the FHU org?

What's the cost?

— Reply to this email directly, view it on GitHub https://github.com/PrayTeam/scriptured-prayer/issues/43#issuecomment-1898970094, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEXUS3WRNXMLK5AR6LMHAPDYPFQANAVCNFSM6AAAAABB5CWQHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYHE3TAMBZGQ . You are receiving this because you were mentioned.Message ID: @.***>

benjoeclark commented 10 months ago

Looks like the cost is $4 per month per user if we were to move the PrayTeam to a paid team.

On Thu, Jan 18, 2024 at 12:10 PM follindown @.***> wrote:

What does that mean?

On Thu, Jan 18, 2024 at 12:05 PM Kenan Casey @.***> wrote:

Is it worth it to move to the FHU org?

What's the cost?

— Reply to this email directly, view it on GitHub < https://github.com/PrayTeam/scriptured-prayer/issues/43#issuecomment-1898970094>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/BEXUS3WRNXMLK5AR6LMHAPDYPFQANAVCNFSM6AAAAABB5CWQHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYHE3TAMBZGQ>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/PrayTeam/scriptured-prayer/issues/43#issuecomment-1898977030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGAKP3XBGMHHFOYEPXQGTYPFQTDAVCNFSM6AAAAABB5CWQHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYHE3TOMBTGA . You are receiving this because you were mentioned.Message ID: @.***>

asherlloyd commented 10 months ago

Self-hosted git, anyone? :grin:

benjoeclark commented 10 months ago

I would like to be in on a chat today if possible. I have another meeting from 1-2 but am free otherwise.

kenancasey commented 10 months ago

Are you on the Discord sever, @benjoeclark ?

kenancasey commented 10 months ago

Do we get protected branches if we move to open-source? What are your thoughts on that?

Soyokaze-42 commented 10 months ago

After our discussion yesterday, I believe we settled on

  1. Publishing the code under the AGPL
  2. Defining and following strict contribution guidelines for code and issues
  3. Setting up branch protection rules
  4. Inviting the students into this repository as members

Did I miss anything or get anything wrong?

benjoeclark commented 10 months ago

Looks right to me.

kenancasey commented 10 months ago

@Soyokaze-42 Would you be willing to help define the contribution and issue guidelines? Are there templates you've seen that we can adopt?

Soyokaze-42 commented 10 months ago

I can help. This is the kanban process I used in programming II: https://github.com/FHU/python-project-template-dev/blob/main/.github/PULL_REQUEST_TEMPLATE/PBL_Develop.md

It was more of a team assignment without individual stories and we did not get close to following it well.

Soyokaze-42 commented 10 months ago

I thought there was an issue template somewhere, too.

asherlloyd commented 10 months ago

@Soyokaze-42 Would you be willing to help define the contribution and issue guidelines? Are there templates you've seen that we can adopt?

Templates added in #47.

kenancasey commented 10 months ago

Students may only work on stories with AC (i.e., stories that have been defined and planned; not feature stories). Student PRs must be approved by Dr. Casey (or another non-student). Students must submit feature requests to product owner.

Soyokaze-42 commented 8 months ago

@asherlloyd @kenancasey Did we ever get the student contribution guidelines written in a markdown file? The acceptance criteria for this one has "Define (and follow) strict contribution guidelines for code and issues" which we discussed being in the markdown file someplace, but I don't see it.

kenancasey commented 8 months ago

Sorry. That's still on my todo list.