Password change script - Githubissues

GreeneGunnar14 commented 4 months ago

Password Change Script

Description

A new command has been added that allows non-django developers to easily change their password in the event they forget it.

Reason

This is a QOL tool for the developers in the FHU Capstone class that are contributing to the project but do not have experience using django.

How this has been tested

I tested changing my password and then logging in to the website. I tested to ensure that the password confirmation/matching was working correctly. I tested running the command with no users in the database.

Types of changes

[ ] New feature (adds functionality)
[ ] Bug fix (fixes an issue)
[ ] Breaking changes (causes defects to existing pieces)
[x ] None of these

Screenshots

Checklist:

[ x] I have read and complied with the CONTRIBUTING document
[ x] The changes I've made follow the existing code style and formatting requirements
[ x] My changes require updates to the documentation, which I have modified accordingly

Soyokaze-42 commented 4 months ago

Is this appreciably better than the changepassword command that comes with Django? https://docs.djangoproject.com/en/5.0/ref/django-admin/#changepassword poetry run python manage.py changepassword [<username>]

asherlloyd commented 4 months ago

@GreeneGunnar14 you refer to "non django developers" in your changes to the README, however, I don't see how this is functionally different from the standard changepassword method via manage.py. What benefit does this new method offer?

GreeneGunnar14 commented 4 months ago

@Soyokaze-42 @asherlloyd To be honest, I had forgotten about the standard changepassword method when working on this. It does have the benefit of a terminal menu that displays the users currently in the database, which could be helpful in the event that someone forgets their username, however I believe that the built in command sufficiently addresses the difficulties I was originally attemting to alleviate.