search

PrayTeam / scriptured-prayer

GNU Affero General Public License v3.0
1 stars 0 forks source link

Feat/about us #91

Closed JudahRininger closed 3 months ago

JudahRininger commented 3 months ago

I added a carousel to the about page with some filler content as well as changing the preexisting content a bit.

Description

I added a Swiper carousel split across a teamContainer.tsx and teamCard.tsx with some filler content and then I changed the background of the original placeholder section and I also added a darkGray color to the color list.

Reason

How this has been tested

Types of changes

Screenshots

Checklist:

asherlloyd commented 3 months ago

This request is very lazy. Considering the wealth of copy-pasted code (tutorial comments included), total disregard of naming conventions, bizarre image choices and failing build - it's clear to me that there is a fundamental misunderstanding of both the React framework and the level of quality that is expected on this project. Consider reading the official guide at https://react.dev/learn.

This request is subsequently closed.

JudahRininger commented 3 months ago

This request is very lazy. Considering the wealth of copy-pasted code (tutorial comments included), total disregard of naming conventions, bizarre image choices and failing build - it's clear to me that there is a fundamental misunderstanding of both the React framework and the level of quality that is expected on this project. Consider reading the official guide at https://react.dev/learn.

This request is subsequently closed.

I did do the code completely myself at first, but then I had to separate it into components and I had no Idea how to do that so I did ask chat GPT how to format my code and separate it into components and that's where the artifacts came from. I'm sure I did a very poor job of separating it into components, because I honestly don't understand how things connect and I really should have looked into that more. The code was mine and not copy pasted at all before I attempted to separate it into components though. I feel a little affronted there because I really did do everything genuinely up to that point. aside from that I'm mainly writing this to ask what exactly you desire from me from here. I understand you want the code implementation of the code itself to meet some standard of quality that I'm falling far short of, but if I manage to make the code itself neat and orderly is what I have acceptable or do you want me to overhaul the way it looks. I honestly suck at frontend design and I acknowledge I probably can't make anything that looks super good without a visual guide. I did make the card and all of the css classes from scratch though so I just want a little bit of direction on whether it looks acceptable and you just want me to overhaul the implementation or it looks horrendous and you want me to overhaul everything in a way that portrays the time I spent on it instead of my incompetence.