search

Prayag2 / kde_modernclock

A modern looking clock widget for KDE Plasma! Written entirely in QML and Javascript, this clock makes your desktop look aesthetic! Inspired by the popular rainmeter skin "Mond".
GNU General Public License v3.0
51 stars 7 forks source link

Port to plasma 6 #4

Closed Kuchenmampfer closed 4 months ago

Kuchenmampfer commented 7 months ago

I have never created a plasma widget, so please check if I have broken anything. However, I followed https://develop.kde.org/docs/plasma/widget/porting_kf6/ and it works in plasmoidviewer for me. So I guess it should be fine like this.

Kuchenmampfer commented 7 months ago

configAppearance is still broken

Kuchenmampfer commented 7 months ago

Alright. Now they work for me. I also threw the appearance page into a scrollable page to make it usable in smaller windows. And I replaced the manual color picker dialog declaration with a color butto provided by kde frameworks.

Kuchenmampfer commented 7 months ago

Hmmm, I see that removes the title of the color dialog. If you don't like that, feel free to revert back to the manual declaration again.

Kuchenmampfer commented 5 months ago

I fixed a few more issues. Now it runs fine in plasmoidviewer, but opening the settings throws a wall of errors:

KQuickPadding is both anonymous and named
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/GlobalSonnetSettings.qml" and "qrc:/qt/qml/org/kde/desktop/private/MobileTextActionsToolBar.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/GlobalSonnetSettings.qml" and "qrc:/qt/qml/org/kde/desktop/private/TextFieldContextMenu.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/MobileTextActionsToolBar.qml" and "qrc:/qt/qml/org/kde/desktop/private/TextFieldContextMenu.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/GlobalSonnetSettings.qml" and "qrc:/qt/qml/org/kde/desktop/MenuItem.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/MobileTextActionsToolBar.qml" and "qrc:/qt/qml/org/kde/desktop/MenuItem.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/TextFieldContextMenu.qml" and "qrc:/qt/qml/org/kde/desktop/MenuItem.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/GlobalSonnetSettings.qml" and "qrc:/qt/qml/org/kde/desktop/private/CheckIndicator.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/MobileTextActionsToolBar.qml" and "qrc:/qt/qml/org/kde/desktop/private/CheckIndicator.qml"
qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/TextFieldContextMenu.qml" and "qrc:/qt/qml/org/kde/desktop/private/CheckIndicator.qml"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/AppletConfiguration.qml:291:9: QML Dialog: Binding loop detected for property "implicitWidth"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/AppletConfiguration.qml:291:9: QML Dialog: Binding loop detected for property "implicitWidth"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:44:9: TypeError: Cannot read property 'implicitHeight' of null
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_objectName"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_day_font_sizeDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_day_letter_spacingDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_show_dayDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_date_font_sizeDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_date_letter_spacingDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_date_formatDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_show_dateDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_time_font_sizeDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_time_letter_spacingDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_time_font_colorDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_show_timeDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_date_font_colorDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_day_font_colorDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_use_24_hour_formatDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_time_characterDefault"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_objectNameChanged"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_valueChanged"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_keys"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_isImmutable"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg_writeConfig"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___0"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___1"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___2"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___3"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___4"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___5"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___6"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___7"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___8"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___9"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___10"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___11"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___12"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___13"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___14"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___15"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___16"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___17"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___18"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___19"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___20"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___21"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___22"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___23"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___24"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___25"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___26"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___27"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___28"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:54: Error: Cannot assign to non-existent property "cfg___29"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:44:9: QML Loader: Binding loop detected for property "height"
file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/configuration/ConfigurationAppletPage.qml:44:9: QML Loader: Binding loop detected for property "height"

As none of these point to the plasmoids code though, I have no idea where to look for a fix.

Prayag2 commented 4 months ago

Thank you so much for the contribution!