Generify Repository Name

PrayagS / polybar-spotify

:musical_note: Spotify status and controls module for Polybar with text scrolling

MIT License

588 stars 38 forks source link

Generify Repository Name #11

Open rlipperts opened 3 years ago

rlipperts commented 3 years ago

When looking for a Polybar plugin to control music playback in chrome with, I scrolled across this multiple times without opening it. The naming suggests that this only works with Spotify, while your code actually is quite generic.

Wouldn't it be good to change the repository name to something like polybar-playerctl? Furthermore, the names of example modules in the readme (and in the hooks in get_spotify_status.sh) would need to be updated.

Edit: Just noticed you mentioned this in one of your commits. I think you should :)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

PrayagS commented 3 years ago

I'm really sorry that I wasn't able to attend to this issue. I agree that most of the traffic comes from Google searches and just renaming should maintain the traffic. However, I think I'll rename it when I've added a bit more features to the module and post it like a new release.

And hence, please keep opening issues for new features. Currently, I'm a little busy but I assure you I'll get back to this issue soon.

rlipperts commented 3 years ago

No Problem. We all have limited time for this (sadly)

fuadsaud commented 3 years ago

I have been using a modified version of this repo in such a way that it's not specific to spotify. It assumes playerctld is running.

However, there's a bug to which I haven't been able to figure out a solution:

Steps to reproduce

Play player A
Play player B (both players will be playing at the same time)
Pause player c

Expected behavior

Play/pause icon should be :pause_button:
Metadata about player A should be displayed

Actual behavior

Play/pause icon is :arrow_forward:
Metadata about player B is displayed

I tried to fix this by using playerctl's --follow flag but without success. I'm still trying to play with it to find a solution.

PrayagS commented 3 years ago

@fuadsaud Can you please open a separate issue?

ulises-jeremias commented 1 year ago

@fuadsaud @PrayagS any update on this? would love to make this module as part of my dotfiles generator once it supports more than spotify 😸