DAMAGE event should be emitted only for damage caused by tower attacks

Praytic / youtd2

Classic community-driven session-based Tower Defense game with RPG elements.

https://youtd2.com/

MIT License

77 stars 15 forks source link

DAMAGE event should be emitted only for damage caused by tower attacks #364

Closed Kvel2D closed 5 months ago

Kvel2D commented 5 months ago

Any calls to do_spell_damage(), do_attack_damage() and AOE variations inside tower scripts should not emit DAMAGE event.

This behavior is according to original JASS code.

Kvel2D commented 1 month ago

DAMAGE even should also be emitted for all instances of damage resulting from splash attacks. Proof: splash attack and damage event

The tower in the screenshot is Ash Geyser. It has a splash attack and an ability which applies a debuff to creeps inside DAMAGE event callback. Ash Geyser did a splash attack on the knight in front. The bigger champion creep got hit by splash attack (not as main target) and it received the debuff.